Finished testing, no more Failures in imageInputTests

imageInput.c

@@ -6,8 +6,6 @@
 #define BUFFER_SIZE 100
 #define FILE_HEADER_STRING "__info2_image_file_format__"
 
-// TODO Implementieren Sie geeignete Hilfsfunktionen für das Lesen der Bildserie aus einer Datei
-
 int checkString (FILE *file){ //Checks if String at the start of File equals expected Format (0 for wrong 1 for right)
 	if (file == NULL){ //returns 0 for empty file
 		return 0;
@@ -30,58 +28,105 @@ int checkString (FILE *file){ //Checks if String at the start of File equals exp
 	}	
 }
 
-void setParameters(FILE* file, unsigned int* imageCount, unsigned int* width, unsigned int* height);
-void allocateMemory(GrayScaleImageSeries *s, const int imageCount, const int width, const int height);
-// TODO Vervollständigen Sie die Funktion readImages unter Benutzung Ihrer Hilfsfunktionen
+static void setParameters(FILE* file, unsigned int* imageCount, unsigned int* width, unsigned int* height);
+static int allocateMemory(GrayScaleImageSeries *series, const int imageCount, const int width, const int height);
+
+
 GrayScaleImageSeries *readImages(const char *path)
 {
 	FILE* file = fopen(path, "rb");
-	// TODO open binary file from file name
-    GrayScaleImageSeries *series = NULL;
-	if(!(checkString(file)))
+    if(!(checkString(file))){
+        fclose(file);
 		return NULL;
+    }
 
-    unsigned int* imageCount = &(series->count); // sets a pointer for int variable count in struct
+    unsigned int width, height; //uninitialised Variables, will be set by setparamters
 
-    setParameters(file, imageCount, &(series->images->width), &(series->images->height));
-    allocateMemory(series, *imageCount, series->images->width, series->images->height);
-	//allocateMemoryLabels();
-	for(int i = (series->images->width * series->images->height) - 1; i <= 0; i--)
-	{
-		fread(&(series->images->buffer[i]), sizeof(GrayScalePixelType), 1, file);
+
+    GrayScaleImageSeries *series = malloc(sizeof(GrayScaleImageSeries)); //Reserving memory for series
+
+    setParameters(file, &(series->count), &width, &height); //setting parameters taken from image file
+
+    if(!allocateMemory(series, series->count, width, height)){
+        clearSeries(series); //If Memory couldnt be correctly allocated a clearing is necessary
+        fclose(file);
+        return NULL;
+    }
+
+
+
+    //Getting image data
+	for(unsigned int i = 0; i < series->count ; i++){ //Iterating for every image
+        for(unsigned int j = 0; j < width * height; j++){ //Iterating for every pixel
+		fread(&(series->images[i].buffer[j]), sizeof(GrayScalePixelType), 1, file);
+        }
+        fread(&(series->labels[i]), sizeof(unsigned char), 1, file); // TODO Added writing in labels array
 	}
 	fclose(file);
     return series;
 }
 
-// TODO Vervollständigen Sie die Funktion clearSeries, welche eine Bildserie vollständig aus dem Speicher freigibt
 void clearSeries(GrayScaleImageSeries *series)
 {
-	for(size_t i = series->count - 1; i >= 0; i--)
+    if (!series)
+        return;
+
+    //Freeing Pixelbuffer for every image
+	for(unsigned int i = 0; i < series->count; i++)
 	{
-		free(series->images+series->count*sizeof(GrayScaleImage)*i);
-		free(series->labels+series->count*sizeof(unsigned char)*i);
+		free(series->images[i].buffer);
 	}
-	series->images = NULL;
-	series->labels = NULL;
+    free(series->images); //Freeing Images array
+
+    free(series->labels); //Freeing Labels
+    free(series); //Freeing Main Structure
+
 }
-void setParameters(FILE* file, unsigned int* imageCount, unsigned int* width, unsigned int* height) { // sets the parameters
-	char buffer[3];
+static void setParameters(FILE* file, unsigned int* imageCount, unsigned int* width, unsigned int* height) { // sets the parameters
+
+	unsigned short buffer[3];
 
 	fseek(file, 27, SEEK_SET);
-	fread(buffer, 1, 3, file);
+    if(fread(buffer, sizeof(unsigned short), 3, file) != 3){ // TODO changed some stuff here, used UNSIGNED SHORT instead of UNSIGNED CHAR!!
+        *imageCount = 0;
+        *width = 0;
+        *height = 0;
+        return;
+    } //Stops if file is too short and clean up
 
-	*imageCount = (int) buffer[0];
-    *width = (int) buffer[1];
-    *height = (int) buffer[2];
-	// TODO allocate memory for labels array (in imageInput.h) -> Done in allocate Memory
-	
-	// TODO read from file and write in 2d arry, write label in labels array, repeat for imageCount	-> done in readImages	
+	*imageCount = (unsigned int) buffer[0];
+
+    *width = (unsigned int) buffer[1];
+
+    *height = (unsigned int) buffer[2];
 }
-// change this to createMatrix?
-void allocateMemory(GrayScaleImageSeries* s, const int imageCount, const int width, const int height) {
-	for (int i = 0; i < imageCount; i++) {
-		s->images[i].buffer = (unsigned char *) malloc(width * height * sizeof(unsigned char)); // allocates memory for every image in the series
-		s->labels = malloc(width * height * sizeof(unsigned char));
+
+static int allocateMemory(GrayScaleImageSeries *series, const int imageCount, const int width, const int height) {
+    series->count = imageCount; //counts number of images in series
+
+    series->images = malloc (sizeof(GrayScaleImage) * imageCount); //Reserving Memory for Images Array
+    if (series->images == NULL)
+        return 0;
+
+
+    series->labels = malloc (series->count * sizeof(unsigned char)); //One Label for every Image
+    if (series->labels == NULL){
+        return 0;}
+
+	for (int i = 0; i < imageCount; i++) { //Reserving Memory for every Images Pixelbuffer and setting width and height
+	    series->images[i].width = width;
+        series->images[i].height = height;
+
+        series->images[i].buffer =  malloc(width * height * sizeof(unsigned char)); // allocates memory for every image in the series
+        if (series->images[i].buffer == NULL){
+            for (int j = 0; j < i; j++){
+                free(series->images[j].buffer);
+                }
+            free(series->images);
+            free(series->labels);
+            return 0;
+        }
+
 	}
+    return 1;
 }

imageInputTests.c

@@ -39,12 +39,16 @@ static void prepareImageFile(const char *path, unsigned short int width, unsigne
 void test_readImagesReturnsCorrectNumberOfImages(void)
 {
     GrayScaleImageSeries *series = NULL;
+
     const unsigned short expectedNumberOfImages = 2;
     const char *path = "testFile.info2";
     prepareImageFile(path, 8, 8, expectedNumberOfImages, 1);
+
     series = readImages(path);
+
     TEST_ASSERT_NOT_NULL(series);
     TEST_ASSERT_EQUAL_UINT16(expectedNumberOfImages, series->count);
+
     clearSeries(series);
     remove(path);
 }

matrix.c

@@ -108,11 +108,17 @@ Matrix add(const Matrix matrix1, const Matrix matrix2)
 Matrix multiply(const Matrix matrix1, const Matrix matrix2)
 {
     Matrix result;
+    result.rows = 0;
+    result.cols = 0;
+    result.buffer = NULL;
+
+    if (matrix1.cols != matrix2.rows) {
+      return result;
+	}
+
     result.rows = matrix1.rows;
     result.cols = matrix2.cols;
 
-    if (matrix1.rows == matrix2.cols) {
-
         result.buffer = malloc(result.rows * result.cols * sizeof(MatrixType));
 
         for(int i = 0; i < result.rows; i++) {
@@ -121,11 +127,8 @@ Matrix multiply(const Matrix matrix1, const Matrix matrix2)
                 for(int k = 0; k < matrix1.cols; k++) {
                     value += matrix1.buffer[i * matrix1.cols + k] * matrix2.buffer[k * matrix2.cols + j];
                 }
-                result.buffer[i * matrix1.cols + j] = value;
+                result.buffer[i * result.cols + j] = value;
             }
-        }
-        return result;
     }
-    printf("Die angegebenen Matrizen haben keine passenden Dimensionen für die Multiplikation");
     return result;
 }