wip

numbers.c

@@ -31,9 +31,7 @@ void createchecknumber(unsigned int len, unsigned int numbers[])
 
     do
     {
-      unsigned int value = 0;
+      unsigned int value = (rand() % (len * 2) + 1);
-      value = (rand() % (len * 2) + 1);
-
       same = 0;
 
       for (unsigned int j = 0; j < i; j++)
@@ -56,6 +54,11 @@ void createchecknumber(unsigned int len, unsigned int numbers[])
 
 unsigned int *createNumbers(unsigned int len)
 {
+  if (len <= 2) //sonst Index-Auswahl-Dauerschleife
+  {
+    return NULL;
+  }
+
   if (RANDOM_SEED == 0)
   {
     srand(time(NULL));
@@ -68,7 +71,7 @@ unsigned int *createNumbers(unsigned int len)
   unsigned int *numbers = malloc(sizeof(unsigned int) * len);
   if (numbers == NULL)
   {
-    return 0;
+    return NULL; 
   }
 
   createchecknumber(len, numbers);
@@ -78,9 +81,6 @@ unsigned int *createNumbers(unsigned int len)
 
   do
   {
-    i = 0;
-    j = 0;
-
     i = rand() % len;
     j = rand() % len;
 
@@ -89,7 +89,6 @@ unsigned int *createNumbers(unsigned int len)
   numbers[i] = numbers[j];
 
   return numbers;
-
 }
 
 void sortnumbers(unsigned int numbers[], unsigned int len)
@@ -109,9 +108,14 @@ void sortnumbers(unsigned int numbers[], unsigned int len)
   }
 }
 
-// Returns only the only number in numbers which is present twice. Returns zero on errors.
+
 unsigned int getDuplicate(const unsigned int numbers[], unsigned int len)
 {
+  if (numbers == NULL || len < 2) // sonst Index-Auswahl-Dauerschleife
+  {
+    return 0;
+  }
+
   unsigned int *copynumbers = malloc(sizeof(unsigned int) * len);
   if (copynumbers == NULL)
   {

stack.c

@@ -8,29 +8,9 @@
     * `clearStack`: gibt den gesamten Speicher frei. */
 
 // Pushes data as pointer onto the stack.
-static StackNode *createEmptyElement()
-{
-    return malloc(sizeof(StackNode));
-}
 StackNode *push(StackNode *stack, void *data)
 {
-    StackNode *newElement = createEmptyElement();
+
-    newElement->data = data;
-    newElement->next = NULL;
-    if (stack == NULL)
-    {
-        stack = newElement;
-    }
-    else
-    {
-        StackNode *currentElement = stack;
-        while(currentElement->next != NULL)
-        {
-            currentElement = currentElement->next;
-        }
-        currentElement->next = newElement;
-    return stack;
-    }
 }
 
 // Deletes the top element of the stack (latest added element) and releases its memory. (Pointer to data has to be

stack.h

@@ -8,11 +8,6 @@ The latest element is taken from the stack. */
 #include <stdlib.h>
 
 //TODO: passenden Datentyp als struct anlegen
-typedef struct node
-{
-    void *data;
-    struct node* next;
-}StackNode;
 
 // Pushes data as pointer onto the stack.
 StackNode *push(StackNode *stack, void *data);

test_stack.c

@@ -1,20 +0,0 @@
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include "stack.h"
-
-void testPushAddsElementCorrectly(void)
-{
-    int a = 10;
-    StackNode *node = push(NULL, &a);
-
-    TEST_ASSERT_NOT_NULL(node);
-    TEST_ASSERT_EQUAL_INT(a, *((int*)node->data)); //void Zeiger in integer-Zeiger umwandeln
-}
-
-int main(void)
-{
-    UNITY_BEGIN();
-    RUN_TEST(testPushAddsElementCorrectly);
-    return UNITY_END();
-}