Compare commits

..

22 Commits

Author SHA1 Message Date
Andrew Onuchowski
2a229ff1c8 Merge remote-tracking branch 'origin/master' 2022-12-21 16:53:00 +01:00
Andrew Onuchowski
57e58ecfaa removed git merge tags; message --> pub struct 2022-12-21 16:52:54 +01:00
f4996f366f cleanup & try to create message obj in client 2022-12-21 16:44:26 +01:00
Andrew Onuchowski
352c6ecffd user iid added to broadcast msg 2022-12-21 16:28:35 +01:00
2ec1342d91
Hochladen 2022-12-21 16:11:09 +01:00
Daniel Laptop
b654f2db36 Merge branch 'master' of https://git.efi.th-nuernberg.de/gitea/hopfma/appsec 2022-12-15 12:56:28 +01:00
Daniel Laptop
3698b82dd8 recive auf tcpstream umgeändert 2022-12-15 12:55:52 +01:00
f36772d9e5 clean up 2022-12-15 12:43:36 +01:00
2b925bdc0d completet crate_vec() 2022-12-15 12:38:21 +01:00
8ad180138e Merge branch 'master' of https://git.efi.th-nuernberg.de/gitea/hopfma/appsec 2022-12-15 12:22:29 +01:00
c399ca6aa3 Merge branch 'master' of https://git.efi.th-nuernberg.de/gitea/hopfma/appsec 2022-12-15 12:22:13 +01:00
Andrew Onuchowski
d06aead691 Merge remote-tracking branch 'origin/master' 2022-12-15 12:21:20 +01:00
2ee738b355 connection_pool;
unencrypted text group chat functional
2022-12-15 12:21:10 +01:00
250fc9a391 added create_vec 2022-12-15 12:17:25 +01:00
Daniel Laptop
2c2b55f776 recvice implementiert. 2022-12-15 12:17:18 +01:00
Daniel Laptop
a635c305d3 angefangen message zu implementieren 2022-12-15 11:28:55 +01:00
e943e4cbb5 Merge branch 'master' of https://git.efi.th-nuernberg.de/gitea/hopfma/appsec 2022-12-01 15:40:34 +01:00
197c72daf5 Merge nach Praktikum 2022-12-01 15:39:43 +01:00
Daniel Laptop
9e5c4126a5 Merge branch 'master' of https://git.efi.th-nuernberg.de/gitea/hopfma/appsec 2022-12-01 12:39:01 +01:00
Daniel Laptop
221a67c536 Konstanten für statusbytes eingefügt 2022-12-01 12:38:53 +01:00
d15eed4f9d move key generation out of func 2022-12-01 12:27:55 +01:00
14c01ca38e Kommentierung 2022-12-01 12:25:18 +01:00
6 changed files with 361 additions and 34 deletions

129
protokoll.txt Normal file
View File

@ -0,0 +1,129 @@
Nachrichtaufbau:
================
u32 src_id // inserted by server
u32 dest_id // 0: to all
u16 size // min: 4
u8 payload[size]
payload[0]: type
KEY_LENGTH=32
Payloads:
=========
0-31 system messages (plaintext)
0 reserved
1 PING
size: 4
u8 type, pad1, pad2, pad3;
2 PONG
size: 4
u8 type, pad1, pad2, pad3;
3 ERROR
size: 4+len
u8 type, severity;
u16 code;
u8 msg[len];
32-63 server side messages (currently plaintext)
32 INIT // first msg from server to new connection
size: 4 + 4*count
u8 type, pad1;
u16 count; // including own; own id is in dest_id
u32 ids[count];
33 JOIN // sent by server; joining id is src_id
size: 4
u8 type, pad1, pad2, pad3;
34 EXIT // sent by server; exiting id is src_id
size: 4
u8 type, pad1, pad2, pad3;
64-95 initial setup messages (plaintext)
64 DH_SETUP // setup secure channel client->client
size: 4 + ?
u8 type, cryptotype, pad2, pad3;
remainder impl-dependend
65 DH_RETURN
size: 4 + ?
u8 type, cryptotype, pad2, pad3;
remainder impl-dependend
96-127 client-client setup messages (DH or old KEY encrypted)
96 AUTHORIZE
T.B.D.
97 KEY_CURRENT
size: 4 + KEY_LENGTH
u8 type, pad1, pad2, pad3;
u8 key[KEY_LENGTH];
98 KEY_NEW
size: 4 + KEY_LENGTH
u8 type, pad1, pad2, pad3;
u8 key[KEY_LENGTH];
128-159 main messages (shared KEY encrypted)
128 MSG
size: 4 + ?
u8 type, pad1;
u16 generation; // which key generation is used. Increasing monotonously, until overflow
u8 msg[];
160-255 reserved
Funktionalität:
===============
- Server: Pakete an alle weiterleiten (dest_id==0) bzw. an nur einen Client (dest_id)
Bei Verbindungsaufbau: Liste aller Clients (Nummern) und eigene Nr (Zufallszahl), JOIN an alle
Bei Verbindungsverlust: EXIT an alle
- Client: Eigentliche Funktionalität
Funktionsweise:
Client: Neue Verbindung
- warten auf INIT
Liste der Clients merken
- Jetzt nur Kommunikation mit zufälligem Client
- -> DH_SETUP
<- DH_RETURN -> client-client DH_KEY
<- KEY_CURRENT (mit DH_KEY verschlüsselt)
-> KEY_NEW an alle (mit KEY_CURRENT verschlüsselt)
- Wenn an irgendeiner Stelle Timeout -> nochmal von vorne mit neuem Client
Nachrichten:
- JOIN
Liste der Clients updaten
- EXIT
Liste der Clients updaten
- DH_SETUP
siehe oben -> DH_RETURN, KEY_CURRENT
- KEY_NEW
Alter KEY xor KEY_NEW -> neuer KEY, generation++
- MSG
generation prüfen, wenn > aktueller, warten auf KEY_NEW etc. (Zwischenspeichern, TODO)
entschlüsseln, MAC prüfen, anzeigen
- ERROR
code + msg ausgeben,
severity >= 64 Key neu aushandeln (TODO),
>= 96 Verbindung neu aufbauen (TODO),
>= 128 Exit
Nachricht schicken:
MSG erstellen, Plaintext mit KEY verschlüsseln + MAC, generation einfügen
Was fehlt / mögliche Fehler und Sicherheitsprobleme:
====================================================
- Keine Authentisierung - jeder kann reingrätschen
- server side messages derzeit plaintext
- keine Validierung (Zertifikate)
- ...

View File

@ -1,25 +1,37 @@
use std::io::Write;
use std::net::TcpStream;
use crypto_box::{
aead::{Aead, AeadCore, OsRng},
SalsaBox, PublicKey, SecretKey
PublicKey, SalsaBox, SecretKey,
};
use std::io::Write;
use std::net::TcpStream;
use crate::message::*;
mod message;
fn main() {
// Server Port
let port: u32 = 7878;
//let stream = TcpStream::connect("172.30.16.1:8080");
//let stream = TcpStream::connect("27.0.0.1:8080");
match TcpStream::connect(format!("localhost:{}", port)) {
Ok(mut stream) => {
println!("Successfully connected to server");
let bob_init_pub_key = PublicKey::from([
0xe8, 0x98, 0xc, 0x86, 0xe0, 0x32, 0xf1, 0xeb,
0x29, 0x75, 0x5, 0x2e, 0x8d, 0x65, 0xbd, 0xdd,
0x15, 0xc3, 0xb5, 0x96, 0x41, 0x17, 0x4e, 0xc9,
0x67, 0x8a, 0x53, 0x78, 0x9d, 0x92, 0xc7, 0x54,
0xe8, 0x98, 0xc, 0x86, 0xe0, 0x32, 0xf1, 0xeb, 0x29, 0x75, 0x5, 0x2e, 0x8d, 0x65,
0xbd, 0xdd, 0x15, 0xc3, 0xb5, 0x96, 0x41, 0x17, 0x4e, 0xc9, 0x67, 0x8a, 0x53, 0x78,
0x9d, 0x92, 0xc7, 0x54,
]);
let (salsa_box, pub_key) = generate_box(bob_init_pub_key.clone());
// Generate a random secret key.
// NOTE: The secret key bytes can be accessed by calling `secret_key.as_bytes()`
let own_secret_key = SecretKey::generate(&mut OsRng);
// Get the public key for the secret key we just generated
let own_public_key = own_secret_key.public_key().clone();
// Create a `SalsaBox` by performing Diffie-Hellman key agreement between
// the two keys.
let salsa_box = SalsaBox::new(&bob_init_pub_key, &own_secret_key);
loop {
let mut buffer = String::new();
@ -40,6 +52,7 @@ fn main() {
// Encrypt the message using the box
let ciphertext = salsa_box.encrypt(&nonce, &plaintext[..]).expect("Fehler");
let message = Message::new(0,0,4, PayloadType::Msg);
println!("Sending {0} as {1:?}", buffer.trim(), plaintext);
stream.write(buffer.as_bytes()).unwrap();
@ -49,11 +62,16 @@ fn main() {
//
// Decrypt the message, using the same randomly generated nonce
let decrypted_plaintext = salsa_box.decrypt(&nonce, &ciphertext[..]).expect("Fehler");
let dec_plain_plaintext = std::str::from_utf8(&*decrypted_plaintext).expect("");
let decrypted_plaintext =
salsa_box.decrypt(&nonce, &ciphertext[..]).expect("Fehler");
let dec_plain_plaintext =
std::str::from_utf8(&*decrypted_plaintext).expect("");
assert_eq!(&plaintext[..], &decrypted_plaintext[..]);
println!("Sent {0:?} as cypher: {1:?}, decrypted: {2:?}, {3}", plaintext, ciphertext, decrypted_plaintext, dec_plain_plaintext);
println!(
"Sent {0:?} as cypher: {1:?}, decrypted: {2:?}, {3}",
plaintext, ciphertext, decrypted_plaintext, dec_plain_plaintext
);
}
Err(error) => {
println!("error: {error}");
@ -68,18 +86,3 @@ fn main() {
}
println!("Terminated.");
}
fn generate_box(partner_public_key: PublicKey) -> (SalsaBox, PublicKey) {
// Generate a random secret key.
// NOTE: The secret key bytes can be accessed by calling `secret_key.as_bytes()`
let own_secret_key = SecretKey::generate(&mut OsRng);
// Get the public key for the secret key we just generated
let own_public_key = own_secret_key.public_key().clone();
// Create a `SalsaBox` by performing Diffie-Hellman key agreement between
// the two keys.
let salsa_box = SalsaBox::new(&partner_public_key, &own_secret_key);
(salsa_box, own_public_key)
}

View File

@ -0,0 +1,69 @@
use std::{
sync::{Arc, Mutex},
collections::HashMap,
net::{TcpStream},
io::{Write},
};
pub struct ConnectionPool{
conns: Arc<Mutex<HashMap<u32, TcpStream>>>,
}
impl ConnectionPool{
pub fn new() -> Self {
ConnectionPool{
conns: Arc::new(Mutex::new(HashMap::new())),
}
}
pub fn add_connection(&self, iid: u32, conn: TcpStream) {
self.conns.lock().unwrap().insert(iid, conn);
}
pub fn del_connection(&self, iid: u32) {
self.conns.lock().unwrap().remove(&iid);
}
pub fn unicast(&self, recv_iid: &u32, msg: &String) {
let mut del_conn = false;
match self.conns.lock().unwrap().get(recv_iid) {
Some(mut conn) => {
if conn.write_all(msg.as_bytes()).is_err() {
del_conn = true;
}
},
None => {
println!("Unknown recv_iid: {:#?}", recv_iid);
return;
}
}
if del_conn{
self.del_connection(*recv_iid);
}
}
pub fn broadcast(&self, sender_iid: &u32, msg: &String) {
let mut del_conns: Vec<u32> = Vec::new();
let mut msg1: String;
msg1 = format!("User {sender_iid}: ").parse().unwrap();
msg1.push_str(msg);
for (iid, mut conn) in self.conns.lock().unwrap().iter() {
if sender_iid.ne(iid){
if conn.write_all(msg1.as_bytes()).is_err() {
del_conns.push(*iid);
continue;
}
else if conn.write_all(b"\n").is_err() {
del_conns.push(*iid);
}
}
}
for iid in del_conns {
self.del_connection(iid);
}
}
}

2
src/bin/constants.rs Normal file
View File

@ -0,0 +1,2 @@
pub const KEYBYTE: u8 = 0b1;
pub const MSGBYTE: u8 = 0b01;

107
src/bin/message.rs Normal file
View File

@ -0,0 +1,107 @@
use std::{
io::{BufReader, Read},
net::TcpStream,
};
const KEYLENGTH: u8 = 32;
pub enum PayloadType {
//0-31 system messages (plaintext)
Ping = 1,
Pong = 2,
Error = 3,
//32 - 63 Serverside messages (currently plaintext)
Init = 32,
Join = 33,
Exit = 34,
//64 -95 initial setup messages(plaintext)
DhSetup = 64,
DhReturn = 65,
//96 - 127 client-client setup messages(DH or old KEY encrypted)
AUTHORIZE = 96,
KeyCurrent = 97,
KeyNew = 98,
//128-159 main messages (shared KEY encrypted)
Msg = 128,
//160-255 reserved
}
pub struct Message {
// Eigenschaften der Klasse
src_id: u32,
dest_id: u32,
size: u16,
payload: Vec<u8>,
}
impl Message {
pub fn new(src_id: u32, dest_id: u32, size: u16, msg_type: PayloadType) -> Message {
let mut msg = Message {
src_id: src_id,
dest_id: dest_id,
size: size,
payload: Vec::with_capacity(size.into()),
};
msg.payload[0] = msg_type as u8;
msg
}
fn creat_vec(&mut self) -> Vec<u8> {
let mut vec: Vec<u8> = vec![0; (10 + self.size).into()];
vec[0] = ((self.src_id >> 24) & 0xff) as u8;
vec[1] = ((self.src_id >> 16) & 0xff) as u8;
vec[2] = ((self.src_id >> 8) & 0xff) as u8;
vec[3] = (self.src_id & 0xff) as u8;
vec[4] = ((self.dest_id >> 24) & 0xff) as u8;
vec[5] = ((self.dest_id >> 16) & 0xff) as u8;
vec[6] = ((self.dest_id >> 8) & 0xff) as u8;
vec[7] = (self.dest_id & 0xff) as u8;
vec[8] = ((self.size >> 8) & 0xff) as u8;
vec[9] = (self.size & 0xff) as u8;
for i in 10..(10 + self.size).into(){
vec[i] = self.payload[i - 10];
}
vec
}
fn receive(stream: TcpStream) -> Message {
let buffreader = BufReader::new(stream);
let mut byte_iterator = buffreader.bytes();
let byte1 = byte_iterator.next().unwrap().unwrap();
let byte2 = byte_iterator.next().unwrap().unwrap();
let byte3 = byte_iterator.next().unwrap().unwrap();
let byte4 = byte_iterator.next().unwrap().unwrap();
let src_id: u32 =
(byte1 << 24) as u32 | (byte2 << 16) as u32 | (byte3 << 8) as u32 | (byte4 << 0) as u32;
let byte5 = byte_iterator.next().unwrap().unwrap();
let byte6 = byte_iterator.next().unwrap().unwrap();
let byte7 = byte_iterator.next().unwrap().unwrap();
let byte8 = byte_iterator.next().unwrap().unwrap();
let dest_id: u32 =
(byte5 << 24) as u32 | (byte6 << 16) as u32 | (byte7 << 8) as u32 | (byte8 << 0) as u32;
let byte9 = byte_iterator.next().unwrap().unwrap();
let byte10 = byte_iterator.next().unwrap().unwrap();
let size = (byte9 << 8) as u16 | (byte10 << 0) as u16;
assert!(size > 0, "Ungültige size größe size = {}", size);
let mut payload = Vec::<u8>::new();
for i in 0..size {
payload.push(byte_iterator.next().unwrap().unwrap());
}
Message {
src_id: src_id,
dest_id: dest_id,
size: size,
payload: payload,
}
}
// Methoden der Klasse
}

View File

@ -2,10 +2,13 @@ use std::{
io::{prelude::*, BufReader, Lines},
net::{TcpListener, TcpStream},
};
use std::sync::{Arc, Mutex};
use std::thread::available_parallelism;
use crate::connection_pool::ConnectionPool;
use crate::thread_pool::ThreadPool;
mod thread_pool;
mod connection_pool;
fn main() {
@ -14,28 +17,40 @@ fn main() {
// create thread pool (size = no. of cpu cores)
let pool = ThreadPool::new(available_parallelism().unwrap().get());
//let pool = ThreadPool::new(2);
let conn_pool = Arc::new(Mutex::new(ConnectionPool::new()));
let mut cc: u32 = 0;
// handling function for incoming requests
for stream in listener.incoming() {
let stream = stream.unwrap();
conn_pool.lock().unwrap().add_connection(cc, stream.try_clone().unwrap());
let ccc = cc;
let cconn_pool = conn_pool.clone();
// pass request to thread pool
pool.execute(|| {
handle_connection(stream);
pool.execute(move || {
handle_connection(stream, ccc, cconn_pool);
});
cc += 1;
}
println!("Shutting down.");
}
fn handle_connection(mut stream: TcpStream) {
fn handle_connection(mut stream: TcpStream, iid: u32, conn_pool: Arc<Mutex<ConnectionPool>>) {
// clone TcpStream for simultaneous receiving and sending
let mut stream2: TcpStream = stream.try_clone().unwrap();
//let mut stream2 = stream.try_clone().unwrap();
// initialize reading buffer (for better performance!)
let buf_reader: BufReader<&mut TcpStream> = BufReader::new(&mut stream);
// request: read received text line by line (continuous until connection closed)
let request: Lines<BufReader<&mut TcpStream>> = buf_reader.lines();
// let request: Bytes<BufReader<&mut TcpStream>> = buf_reader.bytes();
println!("Request: {:#?}", request);
@ -46,8 +61,10 @@ fn handle_connection(mut stream: TcpStream) {
let s = elem.unwrap();
println!("{:?}", s);
conn_pool.lock().unwrap().broadcast(&iid, &s);
// send received line back to sender (append LF)
stream2.write_all(s.as_bytes()).unwrap();
stream2.write_all(b"\n").unwrap();
//stream2.write_all(s.as_bytes()).unwrap();
//stream2.write_all(b"\n").unwrap();
}
}