|
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400 |
- /**
- * @fileoverview Enforces empty lines around comments.
- * @author Jamund Ferguson
- */
- "use strict";
-
- //------------------------------------------------------------------------------
- // Requirements
- //------------------------------------------------------------------------------
-
- const lodash = require("lodash"),
- astUtils = require("../util/ast-utils");
-
- //------------------------------------------------------------------------------
- // Helpers
- //------------------------------------------------------------------------------
-
- /**
- * Return an array with with any line numbers that are empty.
- * @param {Array} lines An array of each line of the file.
- * @returns {Array} An array of line numbers.
- */
- function getEmptyLineNums(lines) {
- const emptyLines = lines.map((line, i) => ({
- code: line.trim(),
- num: i + 1
- })).filter(line => !line.code).map(line => line.num);
-
- return emptyLines;
- }
-
- /**
- * Return an array with with any line numbers that contain comments.
- * @param {Array} comments An array of comment tokens.
- * @returns {Array} An array of line numbers.
- */
- function getCommentLineNums(comments) {
- const lines = [];
-
- comments.forEach(token => {
- const start = token.loc.start.line;
- const end = token.loc.end.line;
-
- lines.push(start, end);
- });
- return lines;
- }
-
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
-
- module.exports = {
- meta: {
- type: "layout",
-
- docs: {
- description: "require empty lines around comments",
- category: "Stylistic Issues",
- recommended: false,
- url: "https://eslint.org/docs/rules/lines-around-comment"
- },
-
- fixable: "whitespace",
-
- schema: [
- {
- type: "object",
- properties: {
- beforeBlockComment: {
- type: "boolean"
- },
- afterBlockComment: {
- type: "boolean"
- },
- beforeLineComment: {
- type: "boolean"
- },
- afterLineComment: {
- type: "boolean"
- },
- allowBlockStart: {
- type: "boolean"
- },
- allowBlockEnd: {
- type: "boolean"
- },
- allowClassStart: {
- type: "boolean"
- },
- allowClassEnd: {
- type: "boolean"
- },
- allowObjectStart: {
- type: "boolean"
- },
- allowObjectEnd: {
- type: "boolean"
- },
- allowArrayStart: {
- type: "boolean"
- },
- allowArrayEnd: {
- type: "boolean"
- },
- ignorePattern: {
- type: "string"
- },
- applyDefaultIgnorePatterns: {
- type: "boolean"
- }
- },
- additionalProperties: false
- }
- ]
- },
-
- create(context) {
-
- const options = context.options[0] ? Object.assign({}, context.options[0]) : {};
- const ignorePattern = options.ignorePattern;
- const defaultIgnoreRegExp = astUtils.COMMENTS_IGNORE_PATTERN;
- const customIgnoreRegExp = new RegExp(ignorePattern);
- const applyDefaultIgnorePatterns = options.applyDefaultIgnorePatterns !== false;
-
-
- options.beforeLineComment = options.beforeLineComment || false;
- options.afterLineComment = options.afterLineComment || false;
- options.beforeBlockComment = typeof options.beforeBlockComment !== "undefined" ? options.beforeBlockComment : true;
- options.afterBlockComment = options.afterBlockComment || false;
- options.allowBlockStart = options.allowBlockStart || false;
- options.allowBlockEnd = options.allowBlockEnd || false;
-
- const sourceCode = context.getSourceCode();
-
- const lines = sourceCode.lines,
- numLines = lines.length + 1,
- comments = sourceCode.getAllComments(),
- commentLines = getCommentLineNums(comments),
- emptyLines = getEmptyLineNums(lines),
- commentAndEmptyLines = commentLines.concat(emptyLines);
-
- /**
- * Returns whether or not comments are on lines starting with or ending with code
- * @param {token} token The comment token to check.
- * @returns {boolean} True if the comment is not alone.
- */
- function codeAroundComment(token) {
- let currentToken = token;
-
- do {
- currentToken = sourceCode.getTokenBefore(currentToken, { includeComments: true });
- } while (currentToken && astUtils.isCommentToken(currentToken));
-
- if (currentToken && astUtils.isTokenOnSameLine(currentToken, token)) {
- return true;
- }
-
- currentToken = token;
- do {
- currentToken = sourceCode.getTokenAfter(currentToken, { includeComments: true });
- } while (currentToken && astUtils.isCommentToken(currentToken));
-
- if (currentToken && astUtils.isTokenOnSameLine(token, currentToken)) {
- return true;
- }
-
- return false;
- }
-
- /**
- * Returns whether or not comments are inside a node type or not.
- * @param {ASTNode} parent The Comment parent node.
- * @param {string} nodeType The parent type to check against.
- * @returns {boolean} True if the comment is inside nodeType.
- */
- function isParentNodeType(parent, nodeType) {
- return parent.type === nodeType ||
- (parent.body && parent.body.type === nodeType) ||
- (parent.consequent && parent.consequent.type === nodeType);
- }
-
- /**
- * Returns the parent node that contains the given token.
- * @param {token} token The token to check.
- * @returns {ASTNode} The parent node that contains the given token.
- */
- function getParentNodeOfToken(token) {
- return sourceCode.getNodeByRangeIndex(token.range[0]);
- }
-
- /**
- * Returns whether or not comments are at the parent start or not.
- * @param {token} token The Comment token.
- * @param {string} nodeType The parent type to check against.
- * @returns {boolean} True if the comment is at parent start.
- */
- function isCommentAtParentStart(token, nodeType) {
- const parent = getParentNodeOfToken(token);
-
- return parent && isParentNodeType(parent, nodeType) &&
- token.loc.start.line - parent.loc.start.line === 1;
- }
-
- /**
- * Returns whether or not comments are at the parent end or not.
- * @param {token} token The Comment token.
- * @param {string} nodeType The parent type to check against.
- * @returns {boolean} True if the comment is at parent end.
- */
- function isCommentAtParentEnd(token, nodeType) {
- const parent = getParentNodeOfToken(token);
-
- return parent && isParentNodeType(parent, nodeType) &&
- parent.loc.end.line - token.loc.end.line === 1;
- }
-
- /**
- * Returns whether or not comments are at the block start or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at block start.
- */
- function isCommentAtBlockStart(token) {
- return isCommentAtParentStart(token, "ClassBody") || isCommentAtParentStart(token, "BlockStatement") || isCommentAtParentStart(token, "SwitchCase");
- }
-
- /**
- * Returns whether or not comments are at the block end or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at block end.
- */
- function isCommentAtBlockEnd(token) {
- return isCommentAtParentEnd(token, "ClassBody") || isCommentAtParentEnd(token, "BlockStatement") || isCommentAtParentEnd(token, "SwitchCase") || isCommentAtParentEnd(token, "SwitchStatement");
- }
-
- /**
- * Returns whether or not comments are at the class start or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at class start.
- */
- function isCommentAtClassStart(token) {
- return isCommentAtParentStart(token, "ClassBody");
- }
-
- /**
- * Returns whether or not comments are at the class end or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at class end.
- */
- function isCommentAtClassEnd(token) {
- return isCommentAtParentEnd(token, "ClassBody");
- }
-
- /**
- * Returns whether or not comments are at the object start or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at object start.
- */
- function isCommentAtObjectStart(token) {
- return isCommentAtParentStart(token, "ObjectExpression") || isCommentAtParentStart(token, "ObjectPattern");
- }
-
- /**
- * Returns whether or not comments are at the object end or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at object end.
- */
- function isCommentAtObjectEnd(token) {
- return isCommentAtParentEnd(token, "ObjectExpression") || isCommentAtParentEnd(token, "ObjectPattern");
- }
-
- /**
- * Returns whether or not comments are at the array start or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at array start.
- */
- function isCommentAtArrayStart(token) {
- return isCommentAtParentStart(token, "ArrayExpression") || isCommentAtParentStart(token, "ArrayPattern");
- }
-
- /**
- * Returns whether or not comments are at the array end or not.
- * @param {token} token The Comment token.
- * @returns {boolean} True if the comment is at array end.
- */
- function isCommentAtArrayEnd(token) {
- return isCommentAtParentEnd(token, "ArrayExpression") || isCommentAtParentEnd(token, "ArrayPattern");
- }
-
- /**
- * Checks if a comment token has lines around it (ignores inline comments)
- * @param {token} token The Comment token.
- * @param {Object} opts Options to determine the newline.
- * @param {boolean} opts.after Should have a newline after this line.
- * @param {boolean} opts.before Should have a newline before this line.
- * @returns {void}
- */
- function checkForEmptyLine(token, opts) {
- if (applyDefaultIgnorePatterns && defaultIgnoreRegExp.test(token.value)) {
- return;
- }
-
- if (ignorePattern && customIgnoreRegExp.test(token.value)) {
- return;
- }
-
- let after = opts.after,
- before = opts.before;
-
- const prevLineNum = token.loc.start.line - 1,
- nextLineNum = token.loc.end.line + 1,
- commentIsNotAlone = codeAroundComment(token);
-
- const blockStartAllowed = options.allowBlockStart &&
- isCommentAtBlockStart(token) &&
- !(options.allowClassStart === false &&
- isCommentAtClassStart(token)),
- blockEndAllowed = options.allowBlockEnd && isCommentAtBlockEnd(token) && !(options.allowClassEnd === false && isCommentAtClassEnd(token)),
- classStartAllowed = options.allowClassStart && isCommentAtClassStart(token),
- classEndAllowed = options.allowClassEnd && isCommentAtClassEnd(token),
- objectStartAllowed = options.allowObjectStart && isCommentAtObjectStart(token),
- objectEndAllowed = options.allowObjectEnd && isCommentAtObjectEnd(token),
- arrayStartAllowed = options.allowArrayStart && isCommentAtArrayStart(token),
- arrayEndAllowed = options.allowArrayEnd && isCommentAtArrayEnd(token);
-
- const exceptionStartAllowed = blockStartAllowed || classStartAllowed || objectStartAllowed || arrayStartAllowed;
- const exceptionEndAllowed = blockEndAllowed || classEndAllowed || objectEndAllowed || arrayEndAllowed;
-
- // ignore top of the file and bottom of the file
- if (prevLineNum < 1) {
- before = false;
- }
- if (nextLineNum >= numLines) {
- after = false;
- }
-
- // we ignore all inline comments
- if (commentIsNotAlone) {
- return;
- }
-
- const previousTokenOrComment = sourceCode.getTokenBefore(token, { includeComments: true });
- const nextTokenOrComment = sourceCode.getTokenAfter(token, { includeComments: true });
-
- // check for newline before
- if (!exceptionStartAllowed && before && !lodash.includes(commentAndEmptyLines, prevLineNum) &&
- !(astUtils.isCommentToken(previousTokenOrComment) && astUtils.isTokenOnSameLine(previousTokenOrComment, token))) {
- const lineStart = token.range[0] - token.loc.start.column;
- const range = [lineStart, lineStart];
-
- context.report({
- node: token,
- message: "Expected line before comment.",
- fix(fixer) {
- return fixer.insertTextBeforeRange(range, "\n");
- }
- });
- }
-
- // check for newline after
- if (!exceptionEndAllowed && after && !lodash.includes(commentAndEmptyLines, nextLineNum) &&
- !(astUtils.isCommentToken(nextTokenOrComment) && astUtils.isTokenOnSameLine(token, nextTokenOrComment))) {
- context.report({
- node: token,
- message: "Expected line after comment.",
- fix(fixer) {
- return fixer.insertTextAfter(token, "\n");
- }
- });
- }
-
- }
-
- //--------------------------------------------------------------------------
- // Public
- //--------------------------------------------------------------------------
-
- return {
- Program() {
- comments.forEach(token => {
- if (token.type === "Line") {
- if (options.beforeLineComment || options.afterLineComment) {
- checkForEmptyLine(token, {
- after: options.afterLineComment,
- before: options.beforeLineComment
- });
- }
- } else if (token.type === "Block") {
- if (options.beforeBlockComment || options.afterBlockComment) {
- checkForEmptyLine(token, {
- after: options.afterBlockComment,
- before: options.beforeBlockComment
- });
- }
- }
- });
- }
- };
- }
- };
|