123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218 |
- /**
- * @fileoverview Rule to flag use constant conditions
- * @author Christian Schulz <http://rndm.de>
- */
-
- "use strict";
-
- //------------------------------------------------------------------------------
- // Rule Definition
- //------------------------------------------------------------------------------
-
- module.exports = {
- meta: {
- type: "problem",
-
- docs: {
- description: "disallow constant expressions in conditions",
- category: "Possible Errors",
- recommended: true,
- url: "https://eslint.org/docs/rules/no-constant-condition"
- },
-
- schema: [
- {
- type: "object",
- properties: {
- checkLoops: {
- type: "boolean"
- }
- },
- additionalProperties: false
- }
- ],
-
- messages: {
- unexpected: "Unexpected constant condition."
- }
- },
-
- create(context) {
- const options = context.options[0] || {},
- checkLoops = options.checkLoops !== false,
- loopSetStack = [];
-
- let loopsInCurrentScope = new Set();
-
- //--------------------------------------------------------------------------
- // Helpers
- //--------------------------------------------------------------------------
-
-
- /**
- * Checks if a branch node of LogicalExpression short circuits the whole condition
- * @param {ASTNode} node The branch of main condition which needs to be checked
- * @param {string} operator The operator of the main LogicalExpression.
- * @returns {boolean} true when condition short circuits whole condition
- */
- function isLogicalIdentity(node, operator) {
- switch (node.type) {
- case "Literal":
- return (operator === "||" && node.value === true) ||
- (operator === "&&" && node.value === false);
-
- case "UnaryExpression":
- return (operator === "&&" && node.operator === "void");
-
- case "LogicalExpression":
- return isLogicalIdentity(node.left, node.operator) ||
- isLogicalIdentity(node.right, node.operator);
-
- // no default
- }
- return false;
- }
-
- /**
- * Checks if a node has a constant truthiness value.
- * @param {ASTNode} node The AST node to check.
- * @param {boolean} inBooleanPosition `false` if checking branch of a condition.
- * `true` in all other cases
- * @returns {Bool} true when node's truthiness is constant
- * @private
- */
- function isConstant(node, inBooleanPosition) {
- switch (node.type) {
- case "Literal":
- case "ArrowFunctionExpression":
- case "FunctionExpression":
- case "ObjectExpression":
- case "ArrayExpression":
- return true;
-
- case "UnaryExpression":
- if (node.operator === "void") {
- return true;
- }
-
- return (node.operator === "typeof" && inBooleanPosition) ||
- isConstant(node.argument, true);
-
- case "BinaryExpression":
- return isConstant(node.left, false) &&
- isConstant(node.right, false) &&
- node.operator !== "in";
-
- case "LogicalExpression": {
- const isLeftConstant = isConstant(node.left, inBooleanPosition);
- const isRightConstant = isConstant(node.right, inBooleanPosition);
- const isLeftShortCircuit = (isLeftConstant && isLogicalIdentity(node.left, node.operator));
- const isRightShortCircuit = (isRightConstant && isLogicalIdentity(node.right, node.operator));
-
- return (isLeftConstant && isRightConstant) || isLeftShortCircuit || isRightShortCircuit;
- }
-
- case "AssignmentExpression":
- return (node.operator === "=") && isConstant(node.right, inBooleanPosition);
-
- case "SequenceExpression":
- return isConstant(node.expressions[node.expressions.length - 1], inBooleanPosition);
-
- // no default
- }
- return false;
- }
-
- /**
- * Tracks when the given node contains a constant condition.
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function trackConstantConditionLoop(node) {
- if (node.test && isConstant(node.test, true)) {
- loopsInCurrentScope.add(node);
- }
- }
-
- /**
- * Reports when the set contains the given constant condition node
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function checkConstantConditionLoopInSet(node) {
- if (loopsInCurrentScope.has(node)) {
- loopsInCurrentScope.delete(node);
- context.report({ node: node.test, messageId: "unexpected" });
- }
- }
-
- /**
- * Reports when the given node contains a constant condition.
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function reportIfConstant(node) {
- if (node.test && isConstant(node.test, true)) {
- context.report({ node: node.test, messageId: "unexpected" });
- }
- }
-
- /**
- * Stores current set of constant loops in loopSetStack temporarily
- * and uses a new set to track constant loops
- * @returns {void}
- * @private
- */
- function enterFunction() {
- loopSetStack.push(loopsInCurrentScope);
- loopsInCurrentScope = new Set();
- }
-
- /**
- * Reports when the set still contains stored constant conditions
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function exitFunction() {
- loopsInCurrentScope = loopSetStack.pop();
- }
-
- /**
- * Checks node when checkLoops option is enabled
- * @param {ASTNode} node The AST node to check.
- * @returns {void}
- * @private
- */
- function checkLoop(node) {
- if (checkLoops) {
- trackConstantConditionLoop(node);
- }
- }
-
- //--------------------------------------------------------------------------
- // Public
- //--------------------------------------------------------------------------
-
- return {
- ConditionalExpression: reportIfConstant,
- IfStatement: reportIfConstant,
- WhileStatement: checkLoop,
- "WhileStatement:exit": checkConstantConditionLoopInSet,
- DoWhileStatement: checkLoop,
- "DoWhileStatement:exit": checkConstantConditionLoopInSet,
- ForStatement: checkLoop,
- "ForStatement > .test": node => checkLoop(node.parent),
- "ForStatement:exit": checkConstantConditionLoopInSet,
- FunctionDeclaration: enterFunction,
- "FunctionDeclaration:exit": exitFunction,
- FunctionExpression: enterFunction,
- "FunctionExpression:exit": exitFunction,
- YieldExpression: () => loopsInCurrentScope.clear()
- };
-
- }
- };
|