Ohm-Management - Projektarbeit B-ME
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

operator-assignment.js 7.7KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209
  1. /**
  2. * @fileoverview Rule to replace assignment expressions with operator assignment
  3. * @author Brandon Mills
  4. */
  5. "use strict";
  6. //------------------------------------------------------------------------------
  7. // Requirements
  8. //------------------------------------------------------------------------------
  9. const astUtils = require("../util/ast-utils");
  10. //------------------------------------------------------------------------------
  11. // Helpers
  12. //------------------------------------------------------------------------------
  13. /**
  14. * Checks whether an operator is commutative and has an operator assignment
  15. * shorthand form.
  16. * @param {string} operator Operator to check.
  17. * @returns {boolean} True if the operator is commutative and has a
  18. * shorthand form.
  19. */
  20. function isCommutativeOperatorWithShorthand(operator) {
  21. return ["*", "&", "^", "|"].indexOf(operator) >= 0;
  22. }
  23. /**
  24. * Checks whether an operator is not commuatative and has an operator assignment
  25. * shorthand form.
  26. * @param {string} operator Operator to check.
  27. * @returns {boolean} True if the operator is not commuatative and has
  28. * a shorthand form.
  29. */
  30. function isNonCommutativeOperatorWithShorthand(operator) {
  31. return ["+", "-", "/", "%", "<<", ">>", ">>>", "**"].indexOf(operator) >= 0;
  32. }
  33. //------------------------------------------------------------------------------
  34. // Rule Definition
  35. //------------------------------------------------------------------------------
  36. /**
  37. * Checks whether two expressions reference the same value. For example:
  38. * a = a
  39. * a.b = a.b
  40. * a[0] = a[0]
  41. * a['b'] = a['b']
  42. * @param {ASTNode} a Left side of the comparison.
  43. * @param {ASTNode} b Right side of the comparison.
  44. * @returns {boolean} True if both sides match and reference the same value.
  45. */
  46. function same(a, b) {
  47. if (a.type !== b.type) {
  48. return false;
  49. }
  50. switch (a.type) {
  51. case "Identifier":
  52. return a.name === b.name;
  53. case "Literal":
  54. return a.value === b.value;
  55. case "MemberExpression":
  56. /*
  57. * x[0] = x[0]
  58. * x[y] = x[y]
  59. * x.y = x.y
  60. */
  61. return same(a.object, b.object) && same(a.property, b.property);
  62. default:
  63. return false;
  64. }
  65. }
  66. /**
  67. * Determines if the left side of a node can be safely fixed (i.e. if it activates the same getters/setters and)
  68. * toString calls regardless of whether assignment shorthand is used)
  69. * @param {ASTNode} node The node on the left side of the expression
  70. * @returns {boolean} `true` if the node can be fixed
  71. */
  72. function canBeFixed(node) {
  73. return node.type === "Identifier" ||
  74. node.type === "MemberExpression" && node.object.type === "Identifier" && (!node.computed || node.property.type === "Literal");
  75. }
  76. module.exports = {
  77. meta: {
  78. type: "suggestion",
  79. docs: {
  80. description: "require or disallow assignment operator shorthand where possible",
  81. category: "Stylistic Issues",
  82. recommended: false,
  83. url: "https://eslint.org/docs/rules/operator-assignment"
  84. },
  85. schema: [
  86. {
  87. enum: ["always", "never"]
  88. }
  89. ],
  90. fixable: "code"
  91. },
  92. create(context) {
  93. const sourceCode = context.getSourceCode();
  94. /**
  95. * Returns the operator token of an AssignmentExpression or BinaryExpression
  96. * @param {ASTNode} node An AssignmentExpression or BinaryExpression node
  97. * @returns {Token} The operator token in the node
  98. */
  99. function getOperatorToken(node) {
  100. return sourceCode.getFirstTokenBetween(node.left, node.right, token => token.value === node.operator);
  101. }
  102. /**
  103. * Ensures that an assignment uses the shorthand form where possible.
  104. * @param {ASTNode} node An AssignmentExpression node.
  105. * @returns {void}
  106. */
  107. function verify(node) {
  108. if (node.operator !== "=" || node.right.type !== "BinaryExpression") {
  109. return;
  110. }
  111. const left = node.left;
  112. const expr = node.right;
  113. const operator = expr.operator;
  114. if (isCommutativeOperatorWithShorthand(operator) || isNonCommutativeOperatorWithShorthand(operator)) {
  115. if (same(left, expr.left)) {
  116. context.report({
  117. node,
  118. message: "Assignment can be replaced with operator assignment.",
  119. fix(fixer) {
  120. if (canBeFixed(left)) {
  121. const equalsToken = getOperatorToken(node);
  122. const operatorToken = getOperatorToken(expr);
  123. const leftText = sourceCode.getText().slice(node.range[0], equalsToken.range[0]);
  124. const rightText = sourceCode.getText().slice(operatorToken.range[1], node.right.range[1]);
  125. return fixer.replaceText(node, `${leftText}${expr.operator}=${rightText}`);
  126. }
  127. return null;
  128. }
  129. });
  130. } else if (same(left, expr.right) && isCommutativeOperatorWithShorthand(operator)) {
  131. /*
  132. * This case can't be fixed safely.
  133. * If `a` and `b` both have custom valueOf() behavior, then fixing `a = b * a` to `a *= b` would
  134. * change the execution order of the valueOf() functions.
  135. */
  136. context.report({
  137. node,
  138. message: "Assignment can be replaced with operator assignment."
  139. });
  140. }
  141. }
  142. }
  143. /**
  144. * Warns if an assignment expression uses operator assignment shorthand.
  145. * @param {ASTNode} node An AssignmentExpression node.
  146. * @returns {void}
  147. */
  148. function prohibit(node) {
  149. if (node.operator !== "=") {
  150. context.report({
  151. node,
  152. message: "Unexpected operator assignment shorthand.",
  153. fix(fixer) {
  154. if (canBeFixed(node.left)) {
  155. const operatorToken = getOperatorToken(node);
  156. const leftText = sourceCode.getText().slice(node.range[0], operatorToken.range[0]);
  157. const newOperator = node.operator.slice(0, -1);
  158. let rightText;
  159. // If this change would modify precedence (e.g. `foo *= bar + 1` => `foo = foo * (bar + 1)`), parenthesize the right side.
  160. if (
  161. astUtils.getPrecedence(node.right) <= astUtils.getPrecedence({ type: "BinaryExpression", operator: newOperator }) &&
  162. !astUtils.isParenthesised(sourceCode, node.right)
  163. ) {
  164. rightText = `${sourceCode.text.slice(operatorToken.range[1], node.right.range[0])}(${sourceCode.getText(node.right)})`;
  165. } else {
  166. rightText = sourceCode.text.slice(operatorToken.range[1], node.range[1]);
  167. }
  168. return fixer.replaceText(node, `${leftText}= ${leftText}${newOperator}${rightText}`);
  169. }
  170. return null;
  171. }
  172. });
  173. }
  174. }
  175. return {
  176. AssignmentExpression: context.options[0] !== "never" ? verify : prohibit
  177. };
  178. }
  179. };