From 5c79c16b46af100c34db66ec12ac4674e6104511 Mon Sep 17 00:00:00 2001
From: Susanne <mahler-susanne@web.de>
Date: Sat, 15 Feb 2025 23:23:21 +0100
Subject: [PATCH] =?UTF-8?q?Refactoring:=20nextGeneration()=20kann=20nun=20?=
 =?UTF-8?q?beliebige=20Zellen=20=C3=BCberpr=C3=BCfen,=20nicht=20mehr=20nur?=
 =?UTF-8?q?=201,1=20aus=20Testfall?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../GameOfLifeAssignment/Life.class           | Bin 1919 -> 2003 bytes
 src/Life.java                                 |  24 ++++++------------
 2 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/out/production/GameOfLifeAssignment/Life.class b/out/production/GameOfLifeAssignment/Life.class
index ba2818f2fa3ee2485fda9a0c78f3fdf1e235daca..7557f176ef2b07a6da82dec80a57aea24a46e748 100644
GIT binary patch
delta 214
zcmey*cbR`f18e;r24)5p1_lPZ-3*M8+Zp71m~CaWwlGNSTg0HlY$pq1$`}DTl3KDd
z+ZeRj7BFyXgIMY<%#6$bKWbqDk{7i%08L<KumX}w3>-kx1W4L22s79+C@?rMXfZf4
z7y#L3KrtHzHwJ5<3N4_mq6~_5Kq)7nRxSo324^6P2`FU;)M5{$Ie;2GfGkD^S0GP>
nf%Pu~7drzZ;~xetMyX#6tUxsRC2J+4*W_fj2aGY3UD&Mwad#*g

delta 129
zcmcc2|DSI|18Zgm12Y2?0|SH9ZU)B4?F@20S}ZKv7_`|IFmP&vSnApvfU?XCRzOmS
zfdxpKFmN!K0ompZ5<pRFpokd61O^8NdmxVkDCYrWF*3M<d5nJ;B-j}kC)=`BGTKev
N&h~&YZt@IvYXCZ;6WRa(

diff --git a/src/Life.java b/src/Life.java
index 59b931b..74abc63 100644
--- a/src/Life.java
+++ b/src/Life.java
@@ -51,8 +51,14 @@ public class Life implements ILife {
   public ILife nextGeneration() {
     Life next = new Life();
 
-    if (countAliveNeighbours(1, 1) == 3) {
-      next.setAlive(1,1);
+    // Refactoring: erst wurde nur Zelle 1,1 (entsprechend dem Testfall) überprüft,
+    // jetzt auf alle Zellen des grids ausgeweitet
+    for (int y = 0; y < grid.length; y++) {
+      for (int x = 0; x < grid[y].length; x++) {
+        if (countAliveNeighbours(x, y) == 3) {
+          next.setAlive(x, y);
+        }
+      }
     }
 
     return next;
@@ -61,18 +67,6 @@ public class Life implements ILife {
   private int countAliveNeighbours(int x, int y) {
     int count = 0;
 
-//    Eine Zelle hat ja 8 Nachbarn,
-//    das wäre die Überprüfung für jede einzelne Zelle herum:
-//    if (isValid(x-1, y-1) && isAlive(x-1, y-1)) count++;
-//    if (isValid(x,   y-1) && isAlive(x,   y-1)) count++;
-//    if (isValid(x+1, y-1) && isAlive(x+1, y-1)) count++;
-//    if (isValid(x-1, y)   && isAlive(x-1, y))   count++;
-//    if (isValid(x+1, y)   && isAlive(x+1, y))   count++;
-//    if (isValid(x-1, y+1) && isAlive(x-1, y+1)) count++;
-//    if (isValid(x,   y+1) && isAlive(x,   y+1)) count++;
-//    if (isValid(x+1, y+1) && isAlive(x+1, y+1)) count++;
-
-//  aber so ist's direkt bisschen "schlanker"
     for (int offset_X = -1; offset_X <= 1; offset_X++) {
       for (int offset_Y = -1; offset_Y <= 1; offset_Y++) {
         if (offset_X == 0 && offset_Y == 0) continue;  // eigene Zelle überspringen
@@ -88,9 +82,7 @@ public class Life implements ILife {
     return count;
   }
 
-  // soll in countAliveNeighbours() genutzt werden
   private boolean isValid(int x, int y) {
-    // überprüft einfach nur, ob Zelle innerhalb der grid-Grenzen liegt
     return x >= 0 && x < grid.length && y >= 0 && y < grid[x].length;
   }
 }
\ No newline at end of file