Software zum Installieren eines Smart-Mirror Frameworks , zum Nutzen von hochschulrelevanten Informationen, auf einem Raspberry-Pi.
You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

no-useless-return.js 12KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305
  1. /**
  2. * @fileoverview Disallow redundant return statements
  3. * @author Teddy Katz
  4. */
  5. "use strict";
  6. //------------------------------------------------------------------------------
  7. // Requirements
  8. //------------------------------------------------------------------------------
  9. const astUtils = require("./utils/ast-utils"),
  10. FixTracker = require("./utils/fix-tracker");
  11. //------------------------------------------------------------------------------
  12. // Helpers
  13. //------------------------------------------------------------------------------
  14. /**
  15. * Removes the given element from the array.
  16. * @param {Array} array The source array to remove.
  17. * @param {any} element The target item to remove.
  18. * @returns {void}
  19. */
  20. function remove(array, element) {
  21. const index = array.indexOf(element);
  22. if (index !== -1) {
  23. array.splice(index, 1);
  24. }
  25. }
  26. /**
  27. * Checks whether it can remove the given return statement or not.
  28. * @param {ASTNode} node The return statement node to check.
  29. * @returns {boolean} `true` if the node is removable.
  30. */
  31. function isRemovable(node) {
  32. return astUtils.STATEMENT_LIST_PARENTS.has(node.parent.type);
  33. }
  34. /**
  35. * Checks whether the given return statement is in a `finally` block or not.
  36. * @param {ASTNode} node The return statement node to check.
  37. * @returns {boolean} `true` if the node is in a `finally` block.
  38. */
  39. function isInFinally(node) {
  40. for (
  41. let currentNode = node;
  42. currentNode && currentNode.parent && !astUtils.isFunction(currentNode);
  43. currentNode = currentNode.parent
  44. ) {
  45. if (currentNode.parent.type === "TryStatement" && currentNode.parent.finalizer === currentNode) {
  46. return true;
  47. }
  48. }
  49. return false;
  50. }
  51. //------------------------------------------------------------------------------
  52. // Rule Definition
  53. //------------------------------------------------------------------------------
  54. module.exports = {
  55. meta: {
  56. type: "suggestion",
  57. docs: {
  58. description: "disallow redundant return statements",
  59. category: "Best Practices",
  60. recommended: false,
  61. url: "https://eslint.org/docs/rules/no-useless-return"
  62. },
  63. fixable: "code",
  64. schema: [],
  65. messages: {
  66. unnecessaryReturn: "Unnecessary return statement."
  67. }
  68. },
  69. create(context) {
  70. const segmentInfoMap = new WeakMap();
  71. const usedUnreachableSegments = new WeakSet();
  72. const sourceCode = context.getSourceCode();
  73. let scopeInfo = null;
  74. /**
  75. * Checks whether the given segment is terminated by a return statement or not.
  76. * @param {CodePathSegment} segment The segment to check.
  77. * @returns {boolean} `true` if the segment is terminated by a return statement, or if it's still a part of unreachable.
  78. */
  79. function isReturned(segment) {
  80. const info = segmentInfoMap.get(segment);
  81. return !info || info.returned;
  82. }
  83. /**
  84. * Collects useless return statements from the given previous segments.
  85. *
  86. * A previous segment may be an unreachable segment.
  87. * In that case, the information object of the unreachable segment is not
  88. * initialized because `onCodePathSegmentStart` event is not notified for
  89. * unreachable segments.
  90. * This goes to the previous segments of the unreachable segment recursively
  91. * if the unreachable segment was generated by a return statement. Otherwise,
  92. * this ignores the unreachable segment.
  93. *
  94. * This behavior would simulate code paths for the case that the return
  95. * statement does not exist.
  96. * @param {ASTNode[]} uselessReturns The collected return statements.
  97. * @param {CodePathSegment[]} prevSegments The previous segments to traverse.
  98. * @param {WeakSet<CodePathSegment>} [providedTraversedSegments] A set of segments that have already been traversed in this call
  99. * @returns {ASTNode[]} `uselessReturns`.
  100. */
  101. function getUselessReturns(uselessReturns, prevSegments, providedTraversedSegments) {
  102. const traversedSegments = providedTraversedSegments || new WeakSet();
  103. for (const segment of prevSegments) {
  104. if (!segment.reachable) {
  105. if (!traversedSegments.has(segment)) {
  106. traversedSegments.add(segment);
  107. getUselessReturns(
  108. uselessReturns,
  109. segment.allPrevSegments.filter(isReturned),
  110. traversedSegments
  111. );
  112. }
  113. continue;
  114. }
  115. uselessReturns.push(...segmentInfoMap.get(segment).uselessReturns);
  116. }
  117. return uselessReturns;
  118. }
  119. /**
  120. * Removes the return statements on the given segment from the useless return
  121. * statement list.
  122. *
  123. * This segment may be an unreachable segment.
  124. * In that case, the information object of the unreachable segment is not
  125. * initialized because `onCodePathSegmentStart` event is not notified for
  126. * unreachable segments.
  127. * This goes to the previous segments of the unreachable segment recursively
  128. * if the unreachable segment was generated by a return statement. Otherwise,
  129. * this ignores the unreachable segment.
  130. *
  131. * This behavior would simulate code paths for the case that the return
  132. * statement does not exist.
  133. * @param {CodePathSegment} segment The segment to get return statements.
  134. * @returns {void}
  135. */
  136. function markReturnStatementsOnSegmentAsUsed(segment) {
  137. if (!segment.reachable) {
  138. usedUnreachableSegments.add(segment);
  139. segment.allPrevSegments
  140. .filter(isReturned)
  141. .filter(prevSegment => !usedUnreachableSegments.has(prevSegment))
  142. .forEach(markReturnStatementsOnSegmentAsUsed);
  143. return;
  144. }
  145. const info = segmentInfoMap.get(segment);
  146. for (const node of info.uselessReturns) {
  147. remove(scopeInfo.uselessReturns, node);
  148. }
  149. info.uselessReturns = [];
  150. }
  151. /**
  152. * Removes the return statements on the current segments from the useless
  153. * return statement list.
  154. *
  155. * This function will be called at every statement except FunctionDeclaration,
  156. * BlockStatement, and BreakStatement.
  157. *
  158. * - FunctionDeclarations are always executed whether it's returned or not.
  159. * - BlockStatements do nothing.
  160. * - BreakStatements go the next merely.
  161. * @returns {void}
  162. */
  163. function markReturnStatementsOnCurrentSegmentsAsUsed() {
  164. scopeInfo
  165. .codePath
  166. .currentSegments
  167. .forEach(markReturnStatementsOnSegmentAsUsed);
  168. }
  169. //----------------------------------------------------------------------
  170. // Public
  171. //----------------------------------------------------------------------
  172. return {
  173. // Makes and pushs a new scope information.
  174. onCodePathStart(codePath) {
  175. scopeInfo = {
  176. upper: scopeInfo,
  177. uselessReturns: [],
  178. codePath
  179. };
  180. },
  181. // Reports useless return statements if exist.
  182. onCodePathEnd() {
  183. for (const node of scopeInfo.uselessReturns) {
  184. context.report({
  185. node,
  186. loc: node.loc,
  187. messageId: "unnecessaryReturn",
  188. fix(fixer) {
  189. if (isRemovable(node) && !sourceCode.getCommentsInside(node).length) {
  190. /*
  191. * Extend the replacement range to include the
  192. * entire function to avoid conflicting with
  193. * no-else-return.
  194. * https://github.com/eslint/eslint/issues/8026
  195. */
  196. return new FixTracker(fixer, sourceCode)
  197. .retainEnclosingFunction(node)
  198. .remove(node);
  199. }
  200. return null;
  201. }
  202. });
  203. }
  204. scopeInfo = scopeInfo.upper;
  205. },
  206. /*
  207. * Initializes segments.
  208. * NOTE: This event is notified for only reachable segments.
  209. */
  210. onCodePathSegmentStart(segment) {
  211. const info = {
  212. uselessReturns: getUselessReturns([], segment.allPrevSegments),
  213. returned: false
  214. };
  215. // Stores the info.
  216. segmentInfoMap.set(segment, info);
  217. },
  218. // Adds ReturnStatement node to check whether it's useless or not.
  219. ReturnStatement(node) {
  220. if (node.argument) {
  221. markReturnStatementsOnCurrentSegmentsAsUsed();
  222. }
  223. if (
  224. node.argument ||
  225. astUtils.isInLoop(node) ||
  226. isInFinally(node) ||
  227. // Ignore `return` statements in unreachable places (https://github.com/eslint/eslint/issues/11647).
  228. !scopeInfo.codePath.currentSegments.some(s => s.reachable)
  229. ) {
  230. return;
  231. }
  232. for (const segment of scopeInfo.codePath.currentSegments) {
  233. const info = segmentInfoMap.get(segment);
  234. if (info) {
  235. info.uselessReturns.push(node);
  236. info.returned = true;
  237. }
  238. }
  239. scopeInfo.uselessReturns.push(node);
  240. },
  241. /*
  242. * Registers for all statement nodes except FunctionDeclaration, BlockStatement, BreakStatement.
  243. * Removes return statements of the current segments from the useless return statement list.
  244. */
  245. ClassDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
  246. ContinueStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  247. DebuggerStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  248. DoWhileStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  249. EmptyStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  250. ExpressionStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  251. ForInStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  252. ForOfStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  253. ForStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  254. IfStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  255. ImportDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
  256. LabeledStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  257. SwitchStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  258. ThrowStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  259. TryStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  260. VariableDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
  261. WhileStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  262. WithStatement: markReturnStatementsOnCurrentSegmentsAsUsed,
  263. ExportNamedDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
  264. ExportDefaultDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed,
  265. ExportAllDeclaration: markReturnStatementsOnCurrentSegmentsAsUsed
  266. };
  267. }
  268. };