aufräumen

.gitignore

@@ -6,6 +6,3 @@ runNumbersTest.exe
 numbers.o
 .vscode/launch.json
 .vscode/settings.json
-*.o
-*.exe
-runBintreeTest

bintree.c

@@ -1,10 +1,7 @@
 #include <string.h>
-#include <stdio.h>
 #include "stack.h"
 #include "bintree.h"
 
-static StackNode *stack;
-static TreeNode *tree = NULL;
 // TODO: binären Suchbaum implementieren
 /*  * `addToTree`: fügt ein neues Element in den Baum ein (rekursiv),
  * `clearTree`: gibt den gesamten Baum frei (rekursiv),
@@ -15,34 +12,8 @@ static TreeNode *tree = NULL;
 // if isDuplicate is NULL, otherwise ignores duplicates and sets isDuplicate to 1 (or to 0 if a new entry is added).
 TreeNode *addToTree(TreeNode *root, const void *data, size_t dataSize, CompareFctType compareFct, int *isDuplicate)
 {
-    if (root == NULL)
-    {
-        TreeNode *newNode = malloc(sizeof(TreeNode));
-        newNode->data = malloc(dataSize);
-        memcpy(newNode->data, data, dataSize);
-        newNode->left = NULL;
-        newNode->right = NULL;
-        return newNode;
-    }
     
-    int cmp = compareFct(root->data, data);
-    if (cmp < 0)
-    {
-        root->left = addToTree(root->left, data, dataSize, compareFct, isDuplicate);
-    }
-    else if (cmp > 0)
-    {
-        root->right = addToTree(root->right, data, dataSize, compareFct, isDuplicate);
-    }
-    else
-    {
-        if (isDuplicate != NULL)
-        {
-            *isDuplicate = 1; // Mark as duplicate if needed.
-        }
-    }
 
-    return root;
 }
 
 // Iterates over the tree given by root. Follows the usage of strtok. If tree is NULL, the next entry of the last tree given is returned in ordering direction.
@@ -50,21 +21,6 @@ TreeNode *addToTree(TreeNode *root, const void *data, size_t dataSize, CompareFc
 // push the top node and push all its left nodes.
 void *nextTreeData(TreeNode *root)
 {
-    if (root != NULL)
-    {
-        clearStack(stack);
-        buildStack(root);
-    }
-
-    if(stack != NULL)
-    {
-        
-        void* data = top(stack);
-        stack = pop(stack);
-        return data;
-    }
-
-    return NULL;
 
 }
 
@@ -80,32 +36,27 @@ void clearTree(TreeNode *root)
     {
         clearTree(root->left);
         free(root->left);
-        root->left = NULL;
     }
-    if (root->right != NULL)
+    else if (root->right != NULL)
     {
         clearTree(root->right);
         free(root->right);
-        root->right = NULL;
     }
-    root = NULL;
+    root->data = NULL;
 }
 
 // Returns the number of entries in the tree given by root.
 unsigned int treeSize(const TreeNode *root)
 {
-    return root == NULL ? 0 : treeSize(root->left) + treeSize(root->right) + 1;
+    int counterL, counterR = 0;
-}
+    if (root->left != NULL)
-
-void buildStack(TreeNode *root)
-{
-    
-    if (root == NULL)
     {
-       return; 
+        counterL = treeSize(root->left) + 1;
+    }
+    else if (root->right != NULL)
+    {
+        counterR = treeSize(root->right) + 1;
     }
 
-    buildStack(root->left);   // biggest first
+    return counterL + counterR;
-    stack = push(stack, root->data);                 // push
-    buildStack(root->right); 
 }

bintree.h

@@ -24,6 +24,4 @@ void clearTree(TreeNode *root);
 // Returns the number of entries in the tree given by root.
 unsigned int treeSize(const TreeNode *root);
 
-void buildStack(TreeNode *root);
-
 #endif

highscore.c

@@ -79,8 +79,6 @@ int addHighscore(const char *name, double timeInSeconds, unsigned int len)
 {
     HighscoreEntry entry = createHighscoreEntry(name, calculateScore(timeInSeconds, len));
     highscoreTree = addToTree(highscoreTree, &entry, sizeof(entry), compareHighscoreEntries, NULL);
-    //HighscoreEntry *temp = highscoreTree->data;
-    //printf("%s%d\n", temp->name, temp->score);
 
     return entry.score;
 }

highscores.txt

@@ -1,5 +1 @@
-nick;9963
+player1;3999
-nick;9946
-simon;4965
-alex;2996
-simon;2996

makefile

@@ -35,7 +35,7 @@ $(program_obj_filesobj_files): %.o: %.c
 # --------------------------
 # Unit Tests
 # --------------------------
-stackTests: stack.o test_stack.c $(unityfolder)/unity.c
+unitTests: stack.o test_stack.c $(unityfolder)/unity.c
 	$(CC) $(FLAGS) -I$(unityfolder) -o runStackTest test_stack.c stack.o $(unityfolder)/unity.c
 
 # --------------------------
@@ -44,12 +44,6 @@ stackTests: stack.o test_stack.c $(unityfolder)/unity.c
 numbersTests: numbers.o test_numbers.c $(unityfolder)/unity.c
 	$(CC) $(FLAGS) -I$(unityfolder) -o runNumbersTest test_numbers.c numbers.o $(unityfolder)/unity.c
 
-# --------------------------
-# bintree.c Tests
-# --------------------------
-bintreeTests: bintree.o test_bintree.c $(unityfolder)/unity.c
-	$(CC) $(FLAGS) -I$(unityfolder) -o runBintreeTest test_bintree.c bintree.o $(unityfolder)/unity.c
-
 # --------------------------
 # Clean
 # --------------------------

numbers.c

@@ -23,8 +23,6 @@ unsigned int checkArray(unsigned int *array, unsigned int len, unsigned int numb
     if (array[i] == number)
     {
       free = 0;
-      break;
-      
     }
   }
 
@@ -34,38 +32,33 @@ unsigned int checkArray(unsigned int *array, unsigned int len, unsigned int numb
 unsigned int *createNumbers(unsigned int len)
 {
   srand(time(NULL));
-  unsigned int *array = (unsigned int *)malloc(len * sizeof(unsigned int));
+  unsigned int *array = (unsigned int*)malloc(len * sizeof(unsigned int));
-  int randomNr, randomPos, filler;
+  int randomNr, counter;
 
-
+  if(array == NULL)
-  if (array == NULL)
   {
-    return NULL; // Fehler
+    return NULL;
-  }
-
-  for (int i = 0; i < len; i++)
-  {
-    array[i] = 0;
   }
 
   for (int i = 0; i < len; i++)
   {
+    counter = 0;
     do
     {
-      array[i] = (rand() % (2 * len))+ 1;
+      if (counter == 9)
-    } while (!checkArray(array, i, array[i]));
+      {
+        return NULL;
+      }
+      
+      randomNr = rand() % (2 * len + 1);
+      counter++;
+    } while (!checkArray(array, i, randomNr));
+
+    array[i] = randomNr;
+    printf("%u ", array[i]);
   }
 
-  randomPos = rand() % len;
+  printf("\n");
-  randomNr = array[randomPos];
-
-  filler = randomPos;
-  while(filler == randomPos)
-  {
-    filler = rand() % len;
-  }
-  array[filler] = randomNr;
-  
   return array;
 }
 

stack.c

@@ -10,24 +10,46 @@
 // Pushes data as pointer onto the stack.
 StackNode *push(StackNode *stack, void *data)
 {
-    StackNode *newNode = malloc(sizeof(StackNode));
+    StackNode *tempNode, *newNode;
-    newNode->data = data;
+
-    newNode->next = stack;  // Set the new node's next pointer to the current top of the stack.
+    newNode = malloc(sizeof(StackNode));
-    return newNode;  // Return the new node as the top of the stack.
+    newNode->value = *(int *)data;
+    newNode->next = NULL;
+
+    if (stack == NULL)
+    {
+        stack = newNode;
+        return stack;
+    }
+
+    tempNode = stack;
+    while (tempNode->next != NULL)
+    {
+        tempNode = tempNode->next;
+    }
+    tempNode->next = newNode;
+
+    return stack;
 }
 
 // Deletes the top element of the stack (latest added element) and releases its memory. (Pointer to data has to be
 // freed by caller.)
 StackNode *pop(StackNode *stack)
 {
+    StackNode *tempNode;
+
     if (stack == NULL)
     {
-        return NULL;  // Nothing to pop if stack is empty.
+        return stack;
     }
 
-    StackNode *tempNode = stack;
+    tempNode = stack;
-    stack = stack->next;  // Move the stack pointer to the next node.
+    while (tempNode->next->next != NULL)
-    free(tempNode);  // Free the old top node.
+    {
+        tempNode = tempNode->next;
+    }
+    free(tempNode->next);
+    tempNode->next = NULL;
 
     return stack;
 }
@@ -35,19 +57,35 @@ StackNode *pop(StackNode *stack)
 // Returns the data of the top element.
 void *top(StackNode *stack)
 {
+    StackNode *tempNode;
+
     if (stack == NULL)
     {
-        return NULL;  // Return NULL if stack is empty.
+        return NULL;
     }
 
-    return stack->data;  // Return the value of the top node.
+    tempNode = stack;
+    while (tempNode->next != NULL)
+    {
+        tempNode = tempNode->next;
+    }
+
+    return &tempNode->value;
 }
 
 // Clears stack and releases all memory.
 void clearStack(StackNode *stack)
 {
-    while (stack != NULL)
+    StackNode *tempNode;
+
+    if (stack == NULL)
     {
-        stack = pop(stack);  // Pop each element and free memory.
+        return;
+    }
+
+    tempNode = stack;
+    while (tempNode != NULL)
+    {
+        tempNode = pop(tempNode);
     }
 }

stack.h

@@ -9,7 +9,7 @@ The latest element is taken from the stack. */
 
 //TODO: passenden Datentyp als struct anlegen
 typedef struct Node {
-    void *data;
+    int value;
     struct Node* next;
 } StackNode;
 

stackTest.c

@@ -1,100 +0,0 @@
-#include "unity.h"
-#include "stack.h"  // Stack-Header-Datei
-#include <stdlib.h>
-
-// Test Setup and Teardown Functions
-void setUp(void) {
-    // Setup code (falls notwendig, wie Initialisierungen)
-}
-
-void tearDown(void) {
-    // Cleanup code (falls notwendig)
-}
-
-// Test for push operation
-void test_push(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Check if the stack is not empty
-    TEST_ASSERT_NOT_NULL(stack);
-
-    // Check if the top element is correct
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(20, *topData);  // The last pushed element should be on top
-}
-
-// Test for pop operation
-void test_pop(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Pop the top element
-    stack = pop(stack);
-
-    // Check if the top element is now the first pushed element
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(10, *topData);  // After popping, the first element should be on top
-
-    // Pop the last element
-    stack = pop(stack);
-
-    // Check if the stack is empty now
-    TEST_ASSERT_NULL(stack);  // Stack should be NULL now
-}
-
-// Test for top operation
-void test_top(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Check the top element
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(20, *topData);  // The top element should be 20 (last pushed)
-
-    // Pop the top element and check the new top
-    stack = pop(stack);
-    topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(10, *topData);  // Now the top element should be 10
-}
-
-// Test for clearStack operation
-void test_clearStack(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Clear the stack
-    clearStack(stack);
-
-    // The stack should be empty now
-    TEST_ASSERT_NULL(stack);  // Stack should be NULL
-}
-
-// Run all tests
-int main(void) {
-    UNITY_BEGIN();
-
-    // Run the individual test functions
-    RUN_TEST(test_push);
-    RUN_TEST(test_pop);
-    RUN_TEST(test_top);
-    RUN_TEST(test_clearStack);
-
-    return UNITY_END();
-}

test_bintree.c

@@ -1,80 +0,0 @@
-#include <stdio.h>
-#include <stdlib.h>
-#include "bintree.h"
-#include "unity.h"
-
-
-void sizeTest()
-{
-    TreeNode *root = (TreeNode *)malloc(sizeof(TreeNode));
-    TreeNode *node1 = (TreeNode *)malloc(sizeof(TreeNode));
-    TreeNode *node2 = (TreeNode *)malloc(sizeof(TreeNode));
-
-    int dataRoot = 2;
-    int dataNode1 = 1;
-    int dataNode2 = 3;
-
-    root->data = &dataRoot;
-    root->left = (TreeNode *)node1;
-    root->right = (TreeNode *)node2;
-
-    node1->data = &dataNode1;
-    node1->left = NULL;
-    node1->right = NULL;
-
-    node2->data = &dataNode2;
-    node2->left = NULL;
-    node2->right = NULL;
-
-    TEST_ASSERT_EQUAL_INT(3,treeSize(root));
-}
-
-void clearTest()
-{
-    TreeNode *root = (TreeNode *)malloc(sizeof(TreeNode));
-    TreeNode *node1 = (TreeNode *)malloc(sizeof(TreeNode));
-    TreeNode *node2 = (TreeNode *)malloc(sizeof(TreeNode));
-
-    int dataRoot = 2;
-    int dataNode1 = 1;
-    int dataNode2 = 3;
-
-    root->data = &dataRoot;
-    root->left = (TreeNode *)node1;
-    root->right = (TreeNode *)node2;
-
-    node1->data = &dataNode1;
-    node1->left = NULL;
-    node1->right = NULL;
-
-    node2->data = &dataNode2;
-    node2->left = NULL;
-    node2->right = NULL;
-
-    TreeNode *ptr = root;
-
-    clearTree(ptr);
-    TEST_ASSERT_EQUAL_INT(0,treeSize(root));
-}
-
-void setUp(void)
-{
-    // Falls notwendig, kann hier Vorbereitungsarbeit gemacht werden
-}
-
-void tearDown(void)
-{
-    // Hier kann Bereinigungsarbeit nach jedem Test durchgeführt werden
-}
-
-int main()
-{
-    UNITY_BEGIN();
-
-    printf("============================\nNumbers tests\n============================\n");
-
-    RUN_TEST(sizeTest);
-    RUN_TEST(clearTest);
-
-    return UNITY_END();
-}

test_stack.c

@@ -3,33 +3,16 @@
 #include "stack.h"
 #include "unity.h"
 
-void test_push(void) {
+void test_push(void)
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Check if the stack is not empty
-    TEST_ASSERT_NOT_NULL(stack);
-
-    // Check if the top element is correct
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(20, *topData);  // The last pushed element should be on top
-}
-
-void test_push1(void)
 {
-    StackNode *testNode = NULL;
+    StackNode *testNode;
     int data = 1;
 
     // Test für leeren Stack
-    testNode = push(testNode, &data);
+    testNode = push(NULL, &data);
     TEST_ASSERT_NOT_NULL(&testNode);
     TEST_ASSERT_NULL(testNode->next);
-    int *temp = testNode->data;
+    TEST_ASSERT_EQUAL_INT(1, testNode->value);
-    TEST_ASSERT_EQUAL_INT(1, *temp);
 
     data = 2;
 
@@ -38,53 +21,26 @@ void test_push1(void)
     TEST_ASSERT_NOT_NULL(&testNode);
     TEST_ASSERT_NOT_NULL(testNode->next);
     TEST_ASSERT_NULL(testNode->next->next);
-    temp = testNode->data;
+    TEST_ASSERT_EQUAL_INT(1, testNode->value);
-    TEST_ASSERT_EQUAL_INT(2, *temp);
+    TEST_ASSERT_EQUAL_INT(2, testNode->next->value);
-    testNode = testNode->next;
-    temp = testNode->data;
-    TEST_ASSERT_EQUAL_INT(1, *temp);
 }
 
-StackNode* setup(void *data, StackNode* next) {
+StackNode* setup(int value, StackNode* next) {
     StackNode* node = malloc(sizeof(StackNode)); // allocate memory on heap
     if (node == NULL) {
         perror("malloc failed");
         exit(EXIT_FAILURE); // or handle the error differently
     }
-    node->data = data;
+    node->value = value;
     node->next = next;
     return node;
 }
-void test_pop(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
 
-    // Push elements to the stack
+void test_pop(void)
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Pop the top element
-    stack = pop(stack);
-
-    // Check if the top element is now the first pushed element
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(10, *topData);  // After popping, the first element should be on top
-
-    // Pop the last element
-    stack = pop(stack);
-
-    // Check if the stack is empty now
-    TEST_ASSERT_NULL(stack);  // Stack should be NULL now
-}
-void test_pop2(void)
 {   
-    int x,y,z;
+    StackNode* node2 = setup(3, NULL);
-    x = 1;
+    StackNode* node1 = setup(2, node2);
-    y = 2;
+    StackNode* header = setup(1, node1);
-    z = 3;
-    StackNode* node2 = setup(&z, NULL);
-    StackNode* node1 = setup(&y, node2);
-    StackNode* header = setup(&x, node1);
     StackNode* temp;
 
     temp = pop(header);
@@ -100,62 +56,21 @@ void test_pop2(void)
     TEST_ASSERT_NULL(node1->next);
 }
 
-void test_top(void) {
+void test_top(void)
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Check the top element
-    int *topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(20, *topData);  // The top element should be 20 (last pushed)
-
-    // Pop the top element and check the new top
-    stack = pop(stack);
-    topData = top(stack);
-    TEST_ASSERT_EQUAL_INT(10, *topData);  // Now the top element should be 10
-}
-
-void test_top2(void)
 {
-    int x,y,z;
+    StackNode* node2 = setup(3, NULL);
-    x = 1;
+    StackNode* node1 = setup(2, node2);
-    y = 2;
+    StackNode* header = setup(1, node1);
-    z = 3;
-    StackNode* node2 = setup(&z, NULL);
-    StackNode* node1 = setup(&y, node2);
-    StackNode* header = setup(&x, node1);
 
     int data = *(int *)top(header);
-    TEST_ASSERT_EQUAL_INT(node2->data, data);
+    TEST_ASSERT_EQUAL_INT(node2->value, data);
-}
-
-void test_clearStack(void) {
-    StackNode *stack = NULL;
-    int data1 = 10, data2 = 20;
-
-    // Push elements to the stack
-    stack = push(stack, &data1);
-    stack = push(stack, &data2);
-
-    // Clear the stack
-    clearStack(stack);
-
-    // The stack should be empty now
-    TEST_ASSERT_NULL(stack);  // Stack should be NULL
 }
 
 void test_clear()
 {
-    int x,y,z;
+    StackNode* node2 = setup(3, NULL);
-    x = 1;
+    StackNode* node1 = setup(2, node2);
-    y = 2;
+    StackNode* header = setup(1, node1);
-    z = 3;
-    StackNode* node2 = setup(&z, NULL);
-    StackNode* node1 = setup(&y, node2);
-    StackNode* header = setup(&x, node1);
     StackNode* temp;
     
     clearStack(header);
@@ -191,7 +106,7 @@ int main()
     RUN_TEST(test_push);
     RUN_TEST(test_pop);
     RUN_TEST(test_top);
-    RUN_TEST(test_clearStack);
+    RUN_TEST(test_clear);
 
     return UNITY_END();
 }